From 2c662dac203b6f3e1b75bd9108851ff62a2aff83 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?P=C4=93teris=20Caune?= <cuu508@gmail.com>
Date: Thu, 26 Aug 2021 12:02:09 +0300
Subject: [PATCH] Fix HTML validation issues

---
 static/css/channels.css                   |  1 +
 templates/accounts/billing.html           |  2 +-
 templates/accounts/profile.html           |  2 ++
 templates/accounts/project.html           |  4 ++--
 templates/front/badges.html               | 13 ++++++-------
 templates/front/channels.html             |  5 +----
 templates/front/my_checks_desktop.html    |  4 ++--
 templates/front/update_timeout_modal.html |  2 +-
 templates/integrations/add_opsgenie.html  |  4 +++-
 templates/integrations/add_shell.html     | 10 ++++------
 templates/integrations/email_form.html    |  2 +-
 templates/integrations/webhook_form.html  | 22 ++++++++++------------
 12 files changed, 34 insertions(+), 37 deletions(-)

diff --git a/static/css/channels.css b/static/css/channels.css
index cf95401f..42e9c4b7 100644
--- a/static/css/channels.css
+++ b/static/css/channels.css
@@ -77,6 +77,7 @@ table.channels-table > tbody > tr > th {
 
 .channel-row .actions {
     text-align: right;
+    padding-right: 16px;
 }
 
 .channel-row .actions form {
diff --git a/templates/accounts/billing.html b/templates/accounts/billing.html
index 18fe1a1c..ab9b5f71 100644
--- a/templates/accounts/billing.html
+++ b/templates/accounts/billing.html
@@ -422,7 +422,7 @@
 
                         <div class="col-sm-6">
                             <div class="form-group">
-                                <label for="postal_Code">
+                                <label for="postal_code">
                                     Postal Code
                                 </label>
                                 <input
diff --git a/templates/accounts/profile.html b/templates/accounts/profile.html
index 58f494a2..cdae1fe9 100644
--- a/templates/accounts/profile.html
+++ b/templates/accounts/profile.html
@@ -82,6 +82,7 @@
                         {% if use_webauthn %}
                         <tr>
                             <th>Security keys</th>
+                            <th></th>
                         </tr>
                         {% for credential in credentials %}
                         <tr>
@@ -104,6 +105,7 @@
 
                         <tr>
                             <th>Authenticator app</th>
+                            <th></th>
                         </tr>
                         {% if profile.totp %}
                         <tr>
diff --git a/templates/accounts/project.html b/templates/accounts/project.html
index b4d6f872..324a253f 100644
--- a/templates/accounts/project.html
+++ b/templates/accounts/project.html
@@ -253,7 +253,7 @@
         </div>
 
         {% if is_owner %}
-        <div class="panel panel-{{ transfer_status|default:'default' }}"">
+        <div class="panel panel-{{ transfer_status|default:'default' }}">
             <div class="panel-body settings-block">
                 <h2>Transfer Ownership</h2>
 
@@ -531,7 +531,7 @@
 
                 {% if memberships %}
                 <div class="form-group">
-                    <label for="update-name-input" class="col-sm-4 control-label">
+                    <label for="new-owner" class="col-sm-4 control-label">
                         Choose owner
                     </label>
                     <div class="col-sm-7">
diff --git a/templates/front/badges.html b/templates/front/badges.html
index a447f131..390f8ee7 100644
--- a/templates/front/badges.html
+++ b/templates/front/badges.html
@@ -30,24 +30,24 @@
         <br />
 
         <div class="btn-group" data-toggle="buttons">
-            <label id="show-svg" class="btn btn-default active" data->
-                <input type="radio" autocomplete="off" checked> SVG
+            <label id="show-svg" class="btn btn-default active">
+                <input type="radio" checked> SVG
             </label>
             <label id="show-json" class="btn btn-default">
-                <input type="radio" autocomplete="off"> JSON
+                <input type="radio"> JSON
             </label>
             <label id="show-shields" class="btn btn-default">
-                <input type="radio" autocomplete="off"> Shields.io
+                <input type="radio"> Shields.io
             </label>
         </div>
         &nbsp;
 
         <div class="btn-group" data-toggle="buttons">
             <label id="show-no-late" class="btn btn-default active">
-                <input type="radio" autocomplete="off" checked> Badge states: <b>up</b> or <b>down</b>
+                <input type="radio" checked> Badge states: <b>up</b> or <b>down</b>
             </label>
             <label id="show-with-late" class="btn btn-default">
-                <input type="radio" autocomplete="off"> Badge states: <b>up</b>, <b>late</b> or <b>down</b>
+                <input type="radio"> Badge states: <b>up</b>, <b>late</b> or <b>down</b>
             </label>
         </div>
 
@@ -129,7 +129,6 @@
                 </tr>
             {% endfor %}
         </table>
-        </div>
     </div>
 </div>
 {% endblock %}
diff --git a/templates/front/channels.html b/templates/front/channels.html
index d84ecd0a..11a22593 100644
--- a/templates/front/channels.html
+++ b/templates/front/channels.html
@@ -167,9 +167,6 @@
                 </button>
                 {% endif %}
             </td>
-            <td>
-
-            </td>
         </tr>
         {% endwith %}
         {% endfor %}
@@ -535,7 +532,7 @@
                 </div>
                 <div class="modal-body">
                     <div class="form-group">
-                        <label for="update-name-input" class="col-sm-2 control-label">
+                        <label class="col-sm-2 control-label">
                             Name
                         </label>
                         <div class="col-sm-10">
diff --git a/templates/front/my_checks_desktop.html b/templates/front/my_checks_desktop.html
index 2eb7ac2d..6daa3ad5 100644
--- a/templates/front/my_checks_desktop.html
+++ b/templates/front/my_checks_desktop.html
@@ -128,12 +128,12 @@
         <td class="actions">
             {% if rw %}
             <button class="btn btn-default pause" type="button">
-                <span class="ic-paused" />
+                <span class="ic-paused"></span>
             </button>
             {% endif %}
 
             <button title="Show Details" class="btn btn-default show-log" type="button">
-                <span class="ic-dots" />
+                <span class="ic-dots"></span>
             </button>
         </td>
     </tr>
diff --git a/templates/front/update_timeout_modal.html b/templates/front/update_timeout_modal.html
index 2038a7bb..d3df1120 100644
--- a/templates/front/update_timeout_modal.html
+++ b/templates/front/update_timeout_modal.html
@@ -94,7 +94,7 @@
                         </div>
                         <div class="col-md-4">
                             <div class="form-group">
-                                <label for="cron-grace">Grace Time</label>
+                                <label for="update-timeout-grace-cron">Grace Time</label>
                                 <div class="input-group">
                                     <input
                                         type="number"
diff --git a/templates/integrations/add_opsgenie.html b/templates/integrations/add_opsgenie.html
index b3a5286a..ebc51663 100644
--- a/templates/integrations/add_opsgenie.html
+++ b/templates/integrations/add_opsgenie.html
@@ -48,7 +48,9 @@
             <span class="step-no"></span>
             <p>The integration needs a <strong>Create and Update Access</strong>
                 permission, make sure it is <strong>checked</strong>.
-            </p>The integration does not need the <strong>Read Access</strong> and
+            </p>
+            <p>
+                The integration does not need the <strong>Read Access</strong> and
                 <strong>Delete Access</strong> checkboxes – make sure they are
                 <strong>unchecked</strong>.
             </p>
diff --git a/templates/integrations/add_shell.html b/templates/integrations/add_shell.html
index bf75749d..dc072edc 100644
--- a/templates/integrations/add_shell.html
+++ b/templates/integrations/add_shell.html
@@ -56,12 +56,10 @@
         </div>
         </div>
 
-        <div class="form-group" class="clearfix">
-            <br>
-            <br>
-            <div class="text-right">
-                <button type="submit" class="btn btn-primary">Save Integration</button>
-            </div>
+        <br>
+        <br>
+        <div class="text-right">
+            <button type="submit" class="btn btn-primary">Save Integration</button>
         </div>
         </form>
 
diff --git a/templates/integrations/email_form.html b/templates/integrations/email_form.html
index 239830ea..94f6d0a9 100644
--- a/templates/integrations/email_form.html
+++ b/templates/integrations/email_form.html
@@ -68,7 +68,6 @@ Email Settings - {{ site_name }}
                         {% if form.up.value %} checked {% endif %}>
                     <span class="checkmark"></span>
                     A check goes <strong>up</strong>
-                    </span>
                     {% if form.down.errors %}
                     <div class="help-block">
                         {{ form.down.errors|join:"" }}
@@ -78,6 +77,7 @@ Email Settings - {{ site_name }}
                     <span class="text-muted">
                     Ticketing system integrations: untick this and avoid creating new tickets
                     when checks come back up.
+                    </span>
                     {% endif %}
                 </label>
             </div>
diff --git a/templates/integrations/webhook_form.html b/templates/integrations/webhook_form.html
index e345e3d0..6c1b06de 100644
--- a/templates/integrations/webhook_form.html
+++ b/templates/integrations/webhook_form.html
@@ -154,18 +154,16 @@
         </div>
         </div>
 
-        <div class="form-group" class="clearfix">
-            <br>
-            <br>
-            <div class="text-right">
-                <button type="submit" class="btn btn-primary">
-                    {% if channel %}
-                    Save Changes
-                    {% else %}
-                    Save Integration
-                    {% endif %}
-                </button>
-            </div>
+        <br>
+        <br>
+        <div class="text-right">
+            <button type="submit" class="btn btn-primary">
+                {% if channel %}
+                Save Changes
+                {% else %}
+                Save Integration
+                {% endif %}
+            </button>
         </div>
         </form>