diff --git a/hc/api/tests/test_notify.py b/hc/api/tests/test_notify.py index 597cccdf..a65d608a 100644 --- a/hc/api/tests/test_notify.py +++ b/hc/api/tests/test_notify.py @@ -162,9 +162,9 @@ class NotifyTestCase(BaseTestCase): self._setup_data("email", "alice@example.org", email_verified=False) self.channel.notify(self.check) - assert Notification.objects.count() == 1 - n = Notification.objects.first() - self.assertEqual(n.error, "Email not verified") + # If an email is not verified, it should be skipped over + # without logging a notification: + self.assertEqual(Notification.objects.count(), 0) self.assertEqual(len(mail.outbox), 0) @patch("hc.api.transports.requests.request") diff --git a/hc/api/transports.py b/hc/api/transports.py index 8293a498..9329bb9d 100644 --- a/hc/api/transports.py +++ b/hc/api/transports.py @@ -70,6 +70,9 @@ class Email(Transport): emails.alert(self.channel.value, ctx, headers) + def is_noop(self, check): + return not self.channel.email_verified + class HttpTransport(Transport):