diff --git a/CHANGELOG.md b/CHANGELOG.md index 1598f7c7..6eec8165 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ All notable changes to this project will be documented in this file. - Handle excessively long email addresses in the signup form - Handle excessively long email addresses in the team member invite form - Don't allow duplicate team memberships +- When copying a check, also copy the "failure keyword" field (#417) ## v1.16.0 - 2020-08-04 diff --git a/hc/front/tests/test_copy.py b/hc/front/tests/test_copy.py index d39e5132..e9b815dc 100644 --- a/hc/front/tests/test_copy.py +++ b/hc/front/tests/test_copy.py @@ -7,6 +7,8 @@ class CopyCheckTestCase(BaseTestCase): super(CopyCheckTestCase, self).setUp() self.check = Check(project=self.project) self.check.name = "Foo" + self.check.subject = "success-keyword" + self.check.subject_fail = "failure-keyword" self.check.save() self.copy_url = "/checks/%s/copy/" % self.check.code @@ -16,6 +18,8 @@ class CopyCheckTestCase(BaseTestCase): r = self.client.post(self.copy_url, follow=True) self.assertContains(r, "This is a brand new check") self.assertContains(r, "Foo (copy)") + self.assertContains(r, "success-keyword") + self.assertContains(r, "failure-keyword") def test_it_obeys_limit(self): self.profile.check_limit = 0 diff --git a/hc/front/views.py b/hc/front/views.py index 4ca448cc..071f9870 100644 --- a/hc/front/views.py +++ b/hc/front/views.py @@ -593,6 +593,7 @@ def copy(request, code): copied.name = check.name + " (copy)" copied.desc, copied.tags = check.desc, check.tags copied.subject = check.subject + copied.subject_fail = check.subject_fail copied.kind = check.kind copied.timeout, copied.grace = check.timeout, check.grace