Cleanup, handle "paused" state in email alerts and reports

hc/api/models.py

@@ -92,7 +92,7 @@ class Check(models.Model):
         return "down"
 
     def in_grace_period(self):
-        if not self.last_ping:
+        if self.status in ("new", "paused"):
             return False
 
         up_ends = self.last_ping + self.timeout

hc/api/tests/test_check_model.py

@@ -27,3 +27,13 @@ class CheckModelTestCase(TestCase):
 
         self.assertTrue(check.in_grace_period())
         self.assertEqual(check.get_status(), "up")
+
+    def test_paused_check_is_not_in_grace_period(self):
+        check = Check()
+
+        check.status = "up"
+        check.last_ping = timezone.now() - timedelta(days=1, minutes=30)
+        self.assertTrue(check.in_grace_period())
+
+        check.status = "paused"
+        self.assertFalse(check.in_grace_period())

hc/front/views.py

@@ -44,7 +44,7 @@ def my_checks(request):
 
             if status == "down":
                 down_tags.add(tag)
-            elif check.in_grace_period() and status != "paused":
+            elif check.in_grace_period():
                 grace_tags.add(tag)
 
     ctx = {

templates/emails/summary-html.html

@@ -57,6 +57,8 @@
         <td>
             {% if check.get_status == "new" %}
                 <span class="badge new">NEW</span>
+            {% elif check.get_status == "paused" %}
+                <span class="badge new">PAUSED</span>
             {% elif check.in_grace_period %}
                 <span class="badge grace">LATE</span>
             {% elif check.get_status == "up" %}