Fetch ping details using HTTP GET, not HTTP POST.

hc/front/tests/test_ping_details.py

@@ -11,12 +11,12 @@ class LastPingTestCase(BaseTestCase):
         Ping.objects.create(owner=check, body="this is body")
 
         self.client.login(username="[email protected]", password="password")
-        r = self.client.post("/checks/%s/last_ping/" % check.code)
+        r = self.client.get("/checks/%s/last_ping/" % check.code)
         self.assertContains(r, "this is body", status_code=200)
 
     def test_it_requires_user(self):
         check = Check.objects.create()
-        r = self.client.post("/checks/%s/last_ping/" % check.code)
+        r = self.client.get("/checks/%s/last_ping/" % check.code)
         self.assertEqual(r.status_code, 403)
 
     def test_it_accepts_n(self):
@@ -29,8 +29,8 @@ class LastPingTestCase(BaseTestCase):
 
         self.client.login(username="[email protected]", password="password")
 
-        r = self.client.post("/checks/%s/pings/1/" % check.code)
+        r = self.client.get("/checks/%s/pings/1/" % check.code)
         self.assertContains(r, "foo-123", status_code=200)
 
-        r = self.client.post("/checks/%s/pings/2/" % check.code)
+        r = self.client.get("/checks/%s/pings/2/" % check.code)
         self.assertContains(r, "bar-456", status_code=200)

hc/front/views.py

@@ -275,7 +275,6 @@ def cron_preview(request):
     return render(request, "front/cron_preview.html", ctx)
 
 
-@require_POST
 def ping_details(request, code, n=None):
     if not request.user.is_authenticated:
         return HttpResponseForbidden()

static/js/checks.js

@@ -44,7 +44,6 @@ $(function () {
 
     $(".last-ping").on("click", function() {
         if (this.innerText == "Never") {
-            showUsage(this);
             return false;
         }
 
@@ -53,14 +52,8 @@ $(function () {
 
         var code = $(this).closest("tr.checks-row").attr("id");
         var lastPingUrl = "/checks/" + code + "/last_ping/";
-        var token = $('input[name=csrfmiddlewaretoken]').val();
-        $.ajax({
-            url: lastPingUrl,
-            type: "post",
-            headers: {"X-CSRFToken": token},
-            success: function(data) {
-                $("#ping-details-body" ).html(data);
-            }
+        $.get(lastPingUrl, function(data) {
+            $("#ping-details-body" ).html(data);
         });
 
         var logUrl = "/checks/" + code + "/log/";

static/js/details.js

@@ -88,15 +88,10 @@ $(function () {
         $("#ping-details-body").text("Updating...");
         $('#ping-details-modal').modal("show");
 
-        var token = $('input[name=csrfmiddlewaretoken]').val();
-        $.ajax({
-            url: this.dataset.url,
-            type: "post",
-            headers: {"X-CSRFToken": token},
-            success: function(data) {
-                $("#ping-details-body" ).html(data);
+        $.get(this.dataset.url, function(data) {
+                $("#ping-details-body").html(data);
             }
-        });
+        );
 
         return false;
     });

static/js/log.js

@@ -3,14 +3,8 @@ $(function () {
         $("#ping-details-body").text("Updating...");
         $('#ping-details-modal').modal("show");
 
-        var token = $('input[name=csrfmiddlewaretoken]').val();
-        $.ajax({
-            url: this.dataset.url,
-            type: "post",
-            headers: {"X-CSRFToken": token},
-            success: function(data) {
-                $("#ping-details-body" ).html(data);
-            }
+        $.get(this.dataset.url, function(data) {
+            $("#ping-details-body" ).html(data);
         });
 
         return false;
@@ -26,7 +20,6 @@ $(function () {
         })
     }
 
-
     $("#format-switcher").click(function(ev) {
         var format = ev.target.getAttribute("data-format");
         switchDateFormat(format);

templates/front/log.html

@@ -144,9 +144,6 @@
             </div>
         </div>
     </div>
-    <form>
-        {% csrf_token %}
-    </form>
 </div>
 
 {% endblock %}