diff --git a/CHANGELOG.md b/CHANGELOG.md index 4fae1271..a0b9e49c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,9 @@ All notable changes to this project will be documented in this file. ## v1.20.0 - Unreleased +## Improvements +- Rename VictorOps -> Splunk On-Call + ## Bug Fixes - Fix downtime summary to handle months when the check didn't exist yet (#472) diff --git a/hc/api/tests/test_notify_victorops.py b/hc/api/tests/test_notify_victorops.py index ab84c4ec..bc021c8c 100644 --- a/hc/api/tests/test_notify_victorops.py +++ b/hc/api/tests/test_notify_victorops.py @@ -41,4 +41,4 @@ class NotifyTestCase(BaseTestCase): self.channel.notify(self.check) n = Notification.objects.get() - self.assertEqual(n.error, "VictorOps notifications are not enabled.") + self.assertEqual(n.error, "Splunk On-Call notifications are not enabled.") diff --git a/hc/api/transports.py b/hc/api/transports.py index 87a85433..371a8295 100644 --- a/hc/api/transports.py +++ b/hc/api/transports.py @@ -414,7 +414,7 @@ class Pushover(HttpTransport): class VictorOps(HttpTransport): def notify(self, check): if not settings.VICTOROPS_ENABLED: - return "VictorOps notifications are not enabled." + return "Splunk On-Call notifications are not enabled." description = tmpl("victorops_description.html", check=check) mtype = "CRITICAL" if check.status == "down" else "RECOVERY" diff --git a/hc/front/tests/test_add_victorops.py b/hc/front/tests/test_add_victorops.py index 88e6d89c..d69282b1 100644 --- a/hc/front/tests/test_add_victorops.py +++ b/hc/front/tests/test_add_victorops.py @@ -11,7 +11,7 @@ class AddVictorOpsTestCase(BaseTestCase): def test_instructions_work(self): self.client.login(username="alice@example.org", password="password") r = self.client.get(self.url) - self.assertContains(r, "incident management system") + self.assertContains(r, "incident management platform") def test_it_works(self): form = {"value": "http://example.org"} diff --git a/static/css/icomoon.css b/static/css/icomoon.css index a92052df..9f637b18 100644 --- a/static/css/icomoon.css +++ b/static/css/icomoon.css @@ -86,7 +86,7 @@ } .ic-victorops:before { content: "\e90f"; - color: #f9af4a; + color: #2d2d2d; } .ic-email:before { content: "\e90a"; diff --git a/static/img/integrations/setup_victorops_1.png b/static/img/integrations/setup_victorops_1.png index 14d79aa3..eae936e3 100644 Binary files a/static/img/integrations/setup_victorops_1.png and b/static/img/integrations/setup_victorops_1.png differ diff --git a/static/img/integrations/setup_victorops_2.png b/static/img/integrations/setup_victorops_2.png index d1bd8c52..0bbd9456 100644 Binary files a/static/img/integrations/setup_victorops_2.png and b/static/img/integrations/setup_victorops_2.png differ diff --git a/static/img/integrations/setup_victorops_3.png b/static/img/integrations/setup_victorops_3.png deleted file mode 100644 index 3eeb66d7..00000000 Binary files a/static/img/integrations/setup_victorops_3.png and /dev/null differ diff --git a/static/img/integrations/victorops.png b/static/img/integrations/victorops.png index 461204fa..f15baf75 100644 Binary files a/static/img/integrations/victorops.png and b/static/img/integrations/victorops.png differ diff --git a/templates/docs/configuring_notifications.html b/templates/docs/configuring_notifications.html index 32281c32..5012a4b1 100644 --- a/templates/docs/configuring_notifications.html +++ b/templates/docs/configuring_notifications.html @@ -34,7 +34,7 @@ The "unused" sends from one month do not carry over to the next month.

If you want to receive repeated notifications for as long as a particular check is down, you have a few different options: