Improve phone number sanitization: remove spaces and hyphens

CHANGELOG.md

@@ -10,6 +10,7 @@ All notable changes to this project will be documented in this file.
 - Update the read-only dashboard's CSS for better mobile support (#442)
 - Reduce the number of SQL queries used in the "Get Checks" API call
 - Add support for script's exit status in ping URLs (#429)
+- Improve phone number sanitization: remove spaces and hyphens
 
 ## v1.17.0 - 2020-10-14
 

hc/front/forms.py

@@ -204,6 +204,7 @@ class AddSmsForm(forms.Form):
         v = self.cleaned_data["value"]
 
         stripped = v.encode("ascii", "ignore").decode("ascii")
+        stripped = stripped.replace(" ", "").replace("-", "")
         if not re.match(r"^\+\d{5,15}$", stripped):
             raise forms.ValidationError("Invalid phone number format.")
 

hc/front/tests/test_add_sms.py

@@ -75,3 +75,23 @@ class AddSmsTestCase(BaseTestCase):
 
         c = Channel.objects.get()
         self.assertEqual(c.phone_number, "+1234567890")
+
+    def test_it_strips_hyphens(self):
+        form = {"label": "My Phone", "value": "+123-4567890"}
+
+        self.client.login(username="[email protected]", password="password")
+        r = self.client.post(self.url, form)
+        self.assertRedirects(r, self.channels_url)
+
+        c = Channel.objects.get()
+        self.assertEqual(c.phone_number, "+1234567890")
+
+    def test_it_strips_spaces(self):
+        form = {"label": "My Phone", "value": "+123 45 678 90"}
+
+        self.client.login(username="[email protected]", password="password")
+        r = self.client.post(self.url, form)
+        self.assertRedirects(r, self.channels_url)
+
+        c = Channel.objects.get()
+        self.assertEqual(c.phone_number, "+1234567890")